setup.sh: add dontConfigure #63520
setup.sh: add dontConfigure #63520
Conversation
|
Screenshot of rendered doc change (built on master) |
| @@ -1283,6 +1283,7 @@ genericBuild() { | |||
| fi | |||
|
|
|||
| for curPhase in $phases; do | |||
| if [[ "$curPhase" = configurePhase && -n "${dontConfigure:-}" ]]; then continue; fi | |||
| if [[ "$curPhase" = buildPhase && -n "${dontBuild:-}" ]]; then continue; fi | |||
There was a problem hiding this comment.
Perhaps we should have doBuild, dontCheck, etc. for completeness?
There was a problem hiding this comment.
Well we have doCheck so there's this interesting use of polarities here.
I'm under the impression that doCheck exists to enable because it's default skipped.
Other phases should not be skipped and be explicitly disabled otherwise.
So I'd think dontUnpack would be the only other one to complete this.
|
If you don't mind I think I'll eliminate a lot of expressions doing and use the proper |
|
@matthewbauer ping |
|
I'm not sure this is preferrable over |
|
I personally very much dislike doing that. Feels more intuitive to me for it actually to be skipped. Any opinion on the perception in #63520 (comment)? |
There's already 21 occurences of this and I've expected this to exist without knowing it had no affect for a while.
worldofpeace
force-pushed
the
dontConfigure
branch
from
e856e0c
to
6d39013
Compare
worldofpeace
force-pushed
the
dontConfigure
branch
from
0d5dcfe
to
3f4a353
Compare
Motivation for this change
People have been using
dontConfigurein expressions expecting that it would disable theconfigurePhase.Let's make this actually do something.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)