elmPackages.{elm-test,elm-analyse..}: tooling additions and fixes #63477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extends the number of available tools for Elm language. 1. fix and move "elm-test" Previously located in nodePackages.elm-test but broken (see binwrap info). Now fixed and located in elmPackages.elm-test 2. add "elm-verify-examples" Generate tests from documentation examples 3. add "elm-upgrade" upgrade assistant using statical analysis 4. add "elm-analyse" static analysis for elm code (linter) 5. move "elm-doc-preview" originally located in nodePackages.elm-upgrade - moved for consistency 6. add "elmi-to-json" transforms elmi files to json - used by other tools like elm-test and elm-verify-examples Node.js based dependencies are defined the same way as nodePackages contaparts but are independent (has it's own packages.json) patch-binwrap.nix is used to as a replacement for binwrap package used by some nodejs dependencies that depends on Haskell binaries (elm-test and elm-verify-examples). BREAKING CHANGE =============== elm-doc-preview (as well as broken elm-test) is now commented in `node-packages-v10.json` and should be removed once new nix-expressions for node10 are generated (out of scope of this PR) There are still 2 outstanding elm related packages in nodePackages 1. elm-oracle - legacy package which is not compatible with elm 0.19 2. elm-live - should be moved in the future I think
ofborg
bot
added
8.has: package (new)
10.rebuild-darwin: 1-10
10.rebuild-linux: 1-10
labels
|
@domenkozar sorry for bothering you again, but I think you're the best person to review this and provide feedback. Please let me know if there is something more I can do in order to get this accepted. Also, @worldofpeace if you think there is someone else who can provide the feedback so we don't overload @domenkozar let me know. I can definitely wait but I would love to get this merged eventually. |
|
@GrahamcOfBorg build elmPackages |
|
Nice work :) If it all builds I'll merge it. |
|
💥 it seems to be all green. Thanks @domenkozar |
pull bot
pushed a commit
to milibopp/nixpkgs
that referenced
this pull request
Jun 25, 2019
Don't import <nixpkgs>, because that is not allowed. Broken by NixOS#63477 cc @turboMaCk
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reincarnation of #62899
Extends the number of available tools for Elm language.
fix and move "elm-test"
Previously located in nodePackages.elm-test but broken (see binwrap info).
Now fixed and located in elmPackages.elm-test
add "elm-verify-examples"
Generate tests from documentation examples
add "elm-upgrade"
upgrade assistant using statical analysis
add "elm-analyse"
static analysis for elm code (linter)
move "elm-doc-preview"
originally located in nodePackages.elm-upgrade - moved for consistency
add "elmi-to-json"
transforms elmi files to json - used by other tools like elm-test and
elm-verify-examples
Node.js based dependencies are defined the same way as nodePackages
contaparts but are independent (has it's own packages.json)
patch-binwrap.nix is used to as a replacement for binwrap package
used by some nodejs dependencies that depends on Haskell binaries
(elm-test and elm-verify-examples).
BREAKING CHANGE
elm-doc-preview (as well as broken elm-test) is now commented
in
node-packages-v10.jsonand should be removed once newnix-expressions for node10 are generated (out of scope of this PR)
There are still 2 outstanding elm related packages in nodePackages
Motivation for this change
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)