Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fail2ban: fix dovecot filter's journalmatch #63600

Merged
merged 1 commit into from Aug 12, 2019

Conversation

steadmon
Copy link
Contributor

The dovecot filter config distributed with fail2ban watches for log
entries with a journalmatch filter of "_SYSTEMD_UNIT=dovecot.service",
but NixOS's Dovecot runs as dovecot2.service. Fix the journalmatch
config to match NixOS's Dovecot.

Motivation for this change

fail2ban doesn't currently work with dovecot because the upstream config uses a different name for the dovecot systemd service than NixOS.

Things done

I'm afraid I am very new to Nix / NixOS and I'm not sure how to test this.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

The dovecot filter config distributed with fail2ban watches for log
entries with a journalmatch filter of "_SYSTEMD_UNIT=dovecot.service",
but NixOS's Dovecot runs as dovecot2.service. Fix the journalmatch
config to match NixOS's Dovecot.
@mmahut
Copy link
Member

mmahut commented Aug 12, 2019

@GrahamcOfBorg build fail2ban

@mmahut
Copy link
Member

mmahut commented Aug 12, 2019

@steadmon thank you for your contribution!

@mmahut mmahut merged commit 86ac9f5 into NixOS:master Aug 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants