Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ocamlPackages.mdx: init at 1.4.0; ocamlPackages.printbox: init at 0.2 #63446

Merged
merged 2 commits into from Jun 20, 2019
Merged

ocamlPackages.mdx: init at 1.4.0; ocamlPackages.printbox: init at 0.2 #63446

merged 2 commits into from Jun 20, 2019

Conversation

romildo
Copy link
Contributor

@romildo romildo commented Jun 18, 2019 •
edited

Motivation for this change

Add:

  • mdx, which allows to execute code blocks inside markdown files
  • printbox, which allows to print nested boxes, lists, arrays, tables in several formats
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@romildo romildo changed the title ocamlPackages.mdx: init at 1.4.0 ocamlPackages.mdx: init at 1.4.0; ocamlPackages.printbox: init at 0.2 Jun 18, 2019
@romildo romildo requested a review from vbgl June 18, 2019 18:32
@vbgl
Copy link
Contributor

vbgl commented Jun 19, 2019

@GrahamcOfBorg build ocamlPackages.printbox

@vbgl vbgl merged commit f0e7c5f into NixOS:master Jun 20, 2019
@romildo romildo deleted the upd.mdx branch June 20, 2019 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbgl vbgl vbgl left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@romildo @vbgl