Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.z3c_checkversions: init at 1.1 #63514

Merged
merged 1 commit into from Feb 9, 2020
Merged

pythonPackages.z3c_checkversions: init at 1.1 #63514

merged 1 commit into from Feb 9, 2020

Conversation

talkara
Copy link
Contributor

@talkara talkara commented Jun 19, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@talkara talkara requested a review from FRidh as a code owner June 19, 2019 11:05
worldofpeace
worldofpeace suggested changes Jun 20, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and builds with all interpreters in nixpkgs.

Can you normalize the attribute name and pname to z3c-checkversions?
(commit msg as well)

@worldofpeace
Copy link
Contributor

@GrahamcOfBorg build python37Packages.z3c-checkversions python27Packages.z3c-checkversions python35Packages.z3c-checkversions python36Packages.z3c-checkversions

@worldofpeace
Copy link
Contributor

worldofpeace commented Jun 20, 2019 •
edited

Thanks, looks prefect. Can you squash the commits @talkara?

@talkara
pythonPackages.z3c_checkversions: init at 1.1
3f0a0de 
pythonPackages.z3c-checkversions: normalize attribute name and pname
z3c_checkversions -> z3c-checkversions

pythonPackages.z3c-checkversions: init at 1.1
@talkara talkara force-pushed the pythonPackages.z3c.checkversions branch from 3f2dc72 to 3f0a0de Compare June 20, 2019 06:58
@FRidh FRidh merged commit ca44e95 into NixOS:master Feb 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace requested changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@talkara @worldofpeace @FRidh