Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fastlane: 2.107.0 -> 2.128.1 #63543

Merged
merged 1 commit into from Jul 29, 2019
Merged

Conversation

nicknovitski
Copy link
Contributor

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • [ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@nicknovitski
Copy link
Contributor Author

Fastlane is released very frequently, so i tried adding an updateScript.

@nicknovitski
Copy link
Contributor Author

I tested and fixed the updateScript, and also ran it to update to the latest version.

@nicknovitski nicknovitski force-pushed the fastlane-2.125 branch 2 times, most recently from 36a16f5 to 878fff8 Compare July 15, 2019 17:42
@nicknovitski
Copy link
Contributor Author

nicknovitski commented Jul 15, 2019

I moved the updateScript into it's own PR (#64822), and removed the bundlerApp change for now.

@nicknovitski nicknovitski changed the title Update fastlane fastlane: 2.107.0 -> 2.127.1 Jul 15, 2019
@nicknovitski nicknovitski changed the title fastlane: 2.107.0 -> 2.127.1 fastlane: 2.107.0 -> 2.128.1 Jul 29, 2019
@Mic92 Mic92 merged commit 071f274 into NixOS:master Jul 29, 2019
@nicknovitski nicknovitski deleted the fastlane-2.125 branch July 29, 2019 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants