Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.msrestazure: 0.6.0 -> 0.6.1 #63542

Merged
merged 2 commits into from Jun 24, 2019
Merged

Conversation

jonringer
Copy link
Contributor

Motivation for this change

Noticed it was out of date

Added myself as a maintainer because my day job is working on AzureML now, so I have a reason to keep this up to date. (This package is fundamental to azure-sdk and azure-cli)

Both packages now run tests. (msrestazure was just collecting 0 tests before)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

$ nix-shell -p nix-review --command "nix-review wip"
...
[17 built, 0.0 MiB DL]
15 package were build:
nixops_1_6_1 python27Packages.azure-mgmt-common python27Packages.azure-mgmt-compute python27Packages.azure-mgmt-network python27Packages.azure-mgmt-resource python27Packages.azure-mgmt-storage python27Packages.msrest python27Packages.msrestazure python37Packages.azure-mgmt-common python37Packages.azure-mgmt-compute python37Packages.azure-mgmt-network python37Packages.azure-mgmt-resource python37Packages.azure-mgmt-storage python37Packages.msrest python37Packages.msrestazure
$ nix path-info -Sh ./result
/nix/store/xxk7gbny0dh67av8lv3hc6jrh41kngrl-python3.7-msrest-0.6.7       113.1M
$ nix path-info -Sh ./result
/nix/store/bnczfr25ysqibway86qj6v8gdpf0yx46-python3.6-msrestazure-0.6.1  113.3M

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants