Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python.pkgs.faker: lift restrictive dependencies #63512

Merged
merged 1 commit into from Jun 19, 2019
Merged

python.pkgs.faker: lift restrictive dependencies #63512

merged 1 commit into from Jun 19, 2019

Conversation

timokau
Copy link
Member

@timokau timokau commented Jun 19, 2019 •
edited

Motivation for this change

Fixes the test suite
joke2k/faker#970

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@timokau timokau requested a review from FRidh as a code owner June 19, 2019 09:11
@timokau
Copy link
Member Author

timokau commented Jun 19, 2019

nix-review shows two unrelated failures, probably also caused by the recent python package set update (paperless and python37Packages.rl-coach). No time to look into these right now, may do it as a followup.

@ofborg ofborg bot requested a review from lovek323 June 19, 2019 09:32
@timokau timokau merged commit 4fa9669 into NixOS:master Jun 19, 2019
@timokau timokau deleted the faker-test-fix branch June 19, 2019 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@lovek323 lovek323 Awaiting requested review from lovek323

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@timokau