Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gnome3.tracker-miners: enable auto_features #63491

Merged
merged 1 commit into from Jun 19, 2019

Conversation

jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Jun 19, 2019

When tracker-miners switched from booleans to features, we were no longer building majority of the miners, since we disable auto_features by default.

cc @worldofpeace

  • built in sandbox on NixOS

When tracker-miners switched from booleans to features, we were no longer building
majority of the miners, since we disable auto_features by default.
@ofborg ofborg bot added the 6.topic: GNOME GNOME desktop environment and its underlying platform label Jun 19, 2019
@ofborg ofborg bot requested review from worldofpeace and hedning June 19, 2019 01:23
@worldofpeace
Copy link
Contributor

Testing now. Looks good though.

@jtojnar
Copy link
Contributor Author

jtojnar commented Jun 19, 2019

#63493 will enable it globally.

Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Activates fine, extract-modules are there.

@jtojnar jtojnar merged commit e0a21aa into NixOS:master Jun 19, 2019
@jtojnar jtojnar deleted the tracker-features branch June 19, 2019 01:56
jtojnar added a commit to jtojnar/nixpkgs that referenced this pull request Jun 25, 2019
We disabled them by default when they were introduced in

NixOS#42994

but enabling them probably makes more sense:

NixOS#54398
NixOS#63491
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants