Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kops: 1.11.1->1.12.1 #63562

Merged
merged 1 commit into from Jun 25, 2019
Merged

kops: 1.11.1->1.12.1 #63562

merged 1 commit into from Jun 25, 2019

Conversation

ari-becker
Copy link
Contributor

Motivation for this change

Package update: https://github.com/kubernetes/kops/releases/tag/1.12.1

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Side note: it would be helpful to have more explicit instructions for how to test. I tried some stuff with nix-build before giving up and submitting this without testing.

matthiasbeyer
matthiasbeyer approved these changes Jun 20, 2019
View reviewed changes
Copy link
Contributor

@matthiasbeyer matthiasbeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff looks good to me.

@jonringer
Copy link
Contributor

nix-review pr 63562 passed
diff LGTM 👍

@nlewo
Copy link
Member

nlewo commented Jun 25, 2019

@GrahamcOfBorg build kops

@nlewo
Copy link
Member

nlewo commented Jun 25, 2019

Thx all of you!

@nlewo nlewo merged commit 880bc93 into NixOS:master Jun 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthiasbeyer matthiasbeyer matthiasbeyer approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ari-becker @jonringer @nlewo @matthiasbeyer @Janik-Haag