Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pre-publishing panels for contributors #16198

Closed
christincooper opened this issue Jun 17, 2019 · 2 comments · Fixed by #16424
Closed

Pre-publishing panels for contributors #16198

christincooper opened this issue Jun 17, 2019 · 2 comments · Fixed by #16424
Labels
[Type] Bug An existing feature does not function as intended

Comments

@christincooper
Copy link

christincooper commented Jun 17, 2019 •
edited

There is a bug when displaying the pre-publish panel for contributor users. A bug report was added to trac but it's suggested to post Gutenberg bugs here on GitHub.

The pre-publish panel (PluginPrePublishPanel):

pre-publish-panel

Is not displayed (with the panels) for users without publishing capability (contributor role etc). So these users see:

pre-publish-panel-contributor

Meaning, any panels we add to PluginPrePublishPanel will not be displayed to contributors.

It was initially there, but because some unwanted panels were displayed for contributors (see #6729), they somehow entirely removed the pre-publish screen for contributors. Probably by mistake, making this essentially a bug. If not, a major design error, because contributors need tips the most.

If we can't fix this bug and add PluginPrePublishPanel for contributors, maybe we can at least introduce something like PluginPreReviewPanel...

Contributor users are the ones who need publishing suggestions the most, as they are submitting a post for review, meaning, they are least familiar with the publishing guidelines of the site.

A great example of how the PluginPrePublishPanel can be used for contributors.

Can we fix this bug and have PluginPrePublishPanel enabled for contributor users?
@swissspidy swissspidy added the [Type] Help Request Help with setup, implementation, or "How do I?" questions. label Jun 17, 2019
@gary-woods
Copy link

gary-woods commented Jun 18, 2019 •
edited

I really have to agree with this. It makes no sense that PluginPrePublishPanel is not displayed to contributor users when they are the ones who need publishing suggestions the most!

Looks like the panels were removed when the visibility panel was accidentally displayed to contributor users, see #6725.

I definitely suggest enabling PluginPrePublishPanel for contributor users as well as the purpose of it is to provide guidance and they need it the most. Alternatively, something like PluginPreReviewPanel could work.

@gary-woods gary-woods mentioned this issue Jun 18, 2019
Closed
3 tasks
@christincooper christincooper mentioned this issue Jun 19, 2019
Merged
7 tasks
@christincooper
Copy link
Author

A bug report has been opened on Trac.

@swissspidy swissspidy added [Type] Bug An existing feature does not function as intended and removed [Type] Help Request Help with setup, implementation, or "How do I?" questions. labels Jul 4, 2019
@swissspidy swissspidy mentioned this issue Jul 4, 2019
Closed
@jorgefilipecosta jorgefilipecosta mentioned this issue Jul 4, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: Show pre publish panel items for contributors WordPress/gutenberg
3 participants
@swissspidy @gary-woods @christincooper