Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sage: fix threejs r105 [19.03] #63561

Merged
merged 2 commits into from Jun 20, 2019
Merged

sage: fix threejs r105 [19.03] #63561

merged 2 commits into from Jun 20, 2019

Conversation

timokau
Copy link
Member

@timokau timokau commented Jun 20, 2019 •
edited

Motivation for this change

Backport of bugfix in #63560.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@timokau timokau changed the title Sage threejs r105 19.03 sage: fix threejs r105 [19.03] Jun 20, 2019
@timokau timokau mentioned this pull request Jun 20, 2019
Closed
@timokau timokau merged commit 774d390 into NixOS:release-19.03 Jun 20, 2019
@timokau timokau deleted the sage-threejs-r105-19.03 branch June 20, 2019 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@timokau