Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eksctl: 0.1.35 -> 0.1.38 #63526

Merged
merged 1 commit into from Jun 21, 2019
Merged

eksctl: 0.1.35 -> 0.1.38 #63526

merged 1 commit into from Jun 21, 2019

Conversation

xrelkd
Copy link
Contributor

@xrelkd xrelkd commented Jun 19, 2019 •
edited

Motivation for this change

Update eksctl to the latest release.
https://github.com/weaveworks/eksctl/releases/tag/0.1.38

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@xrelkd xrelkd changed the title eksctl: 0.1.35 -> 0.1.36 eksctl: 0.1.35 -> 0.1.37 Jun 20, 2019
@xrelkd xrelkd changed the title eksctl: 0.1.35 -> 0.1.37 eksctl: 0.1.35 -> 0.1.38 Jun 21, 2019
@xrelkd
Copy link
Contributor Author

xrelkd commented Jun 21, 2019

@marsam I think that this PR gets stuck.
Could you review this PR?
Thank you!!

@marsam
Copy link
Contributor

marsam commented Jun 21, 2019

Thanks! LGTM
@GrahamcOfBorg build eksctl

@marsam marsam merged commit ac5952b into NixOS:master Jun 21, 2019
@xrelkd xrelkd deleted the update/eksctl branch June 22, 2019 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@xrelkd @marsam