Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cum: init at 0.9.1 #63498

Merged
merged 1 commit into from Jun 19, 2019
Merged

cum: init at 0.9.1 #63498

merged 1 commit into from Jun 19, 2019

Conversation

tadeokondrak
Copy link
Member

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jbaum98
Copy link
Contributor

jbaum98 commented Jun 19, 2019

Reviewed points
  • package path fits guidelines
  • package name fits guidelines
  • package version fits guidelines
  • package build on x86_64-linux
  • executables tested on x86_64-linux
  • meta.description is set and fits guidelines
  • meta.license fits upstream license
  • meta.platforms is set
  • meta.maintainers is set
  • build time only dependencies are declared in nativeBuildInputs
  • source is fetched using the appropriate function
  • phases are respected
  • patches that are remotely available are fetched with fetchpatch
Possible improvements
  • Is there a reason you're fetching from GitHub and not from PyPi? I think when possible its preferred to use PyPi, but I could be wrong.
  • Why do you remove the license and tests? Are the tests broken? If so you might want to document the reason in a comment, so that they can be enabled if they're fixed.
Comments

@tadeokondrak
Copy link
Member Author

Is there a reason you're fetching from GitHub and not from PyPi? I think when possible its preferred to use PyPi, but I could be wrong.

I was under the impression that this was mostly for libraries, but looking through other packages it seems like PyPi is preferred, changed.

Why do you remove the license and tests? Are the tests broken? If so you might want to document the reason in a comment, so that they can be enabled if they're fixed.

Added comment.

@etu
Copy link
Contributor

etu commented Jun 19, 2019

@GrahamcOfBorg build cum

@etu etu merged commit 7fd23d1 into NixOS:master Jun 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants