Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xtrace: 1.3.1 -> 1.4.0 #63592

Merged
merged 1 commit into from Jun 25, 2019
Merged

xtrace: 1.3.1 -> 1.4.0 #63592

merged 1 commit into from Jun 25, 2019

Conversation

layus
Copy link
Member

@layus layus commented Jun 20, 2019

Motivation for this change

This one could not be updated automatically anymore. The source
repository has changed.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@nixos-discourse
Copy link

This pull request has been mentioned on Nix community. There might be relevant details there:

https://discourse.nixos.org/t/nixpkgs-update-r-ryantm-logs/1464/28

@ofborg ofborg bot requested a review from viric June 20, 2019 21:52
jtojnar
jtojnar requested changes Jun 20, 2019
View reviewed changes
pkgs/tools/X11/xtrace/default.nix Outdated Show resolved Hide resolved
@FRidh
Copy link
Member

FRidh commented Jun 21, 2019

@GrahamcOfBorg build xtrace

@worldofpeace worldofpeace merged commit 9638d85 into NixOS:master Jun 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar jtojnar requested changes

@viric viric Awaiting requested review from viric

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@layus @nixos-discourse @FRidh @jtojnar @worldofpeace