Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

firefox.updateScript: gpg improvements #63478

Merged
merged 2 commits into from Jun 18, 2019
Merged

firefox.updateScript: gpg improvements #63478

merged 2 commits into from Jun 18, 2019

Conversation

alyssais
Copy link
Member

Motivation for this change

Updating the key by hand every time it expired was annoying and could lead to human error.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@alyssais
firefox-bin.updateScript: always use up-to-date key
b0002f4 
Otherwise we have to keep fetching a new key manually each time they
renew it.
@alyssais
firefox-bin.updateScript: fix with GNUPGHOME
aee879c 
If GNUPGHOME is set in the environment, it takes precedence over HOME,
so to avoid using a user's actual GNUPGHOME, we should override thiscc
instead of HOME.
@alyssais alyssais requested a review from grahamc June 18, 2019 19:49
@andir andir merged commit 0829018 into NixOS:master Jun 18, 2019
@alyssais alyssais deleted the firefox-update branch June 18, 2019 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grahamc grahamc Awaiting requested review from grahamc

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alyssais @andir