-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mystorm BlackIce support #6
Conversation
nmigen_boards/blackice.py
Outdated
|
||
class BlackIcePlatform(LatticeICE40Platform): | ||
device = "iCE40HX8K" | ||
package = "TQ144:4K" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't seem right. I think it should be:
device = "iCE40HX4K"
package = "TQ144"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I haven't realized the need for the :4K
suffix. It should not be necessary anymore after m-labs/nmigen@23ed888.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in latest push
nmigen_boards/blackice.py
Outdated
), | ||
] | ||
|
||
connectors = [ # TODO: check order of top/bottom row |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this still a TODO? I don't understand what it says anyway.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, forgot to remove comment for BlackIce.
Based file on migen boards file and there the double PMOD connectors were split in two. I joined them but made note to check if top row and bottom row matched. As I used the PMOD connectors now the correctness has been verified.
Solved in latest push.
] | ||
|
||
connectors = [ # TODO: check order of top/bottom row | ||
Connector("pmod", 0, " 94 91 88 85 - - 95 93 90 87 - -"), # PMOD1/2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we should use nicer naming than this...
Both onboard SRAM and PMOD connectors have been tested.