New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python3Packages.hiredis-py: init at 1.0.0 #63509
Conversation
5a92b34
to
0083985
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, please do not add yourself as a maintainer in the same commit, please split that into a seperate commit!
, fetchurl | ||
, buildPythonPackage | ||
}: | ||
buildPythonPackage rec { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure whether you need rec
here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had removed rec
and split adding myself to maintainers into another commit.
You are still adding yourself in the maintainers file in a commit that also alters a package... please split that commit. |
I separated them into two commits in this PR and my other open PRs. Are you requesting that I make a separate PR to add myself as a maintainer? |
No, only that you add yourself in the maintainers in a separate commit. |
Merging multiple PRs |
Motivation for this change
Require package for a project.
Things done
Added python package "hiredis-py" to repo.
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)