Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helix #442

Closed
wants to merge 1 commit into from
Closed

Helix #442

wants to merge 1 commit into from

Conversation

phkahler
Copy link
Member

Implements Helical extrusions (#389) via menu or SHIFT-H. Requires a point and axis to be selected. Points on-axis can be dragged along the axis. Points off-axis can be dragged to twist the extrusion. The axis can be any direction, in-sketch or perpendicular are probably most common uses.

@phkahler phkahler force-pushed the helix branch 2 times, most recently from edf4bf7 to ff07d55 Compare July 7, 2019 19:41
@phkahler
Copy link
Member Author

@whitequark Is there anything more you need from me on this? I'm hoping to try a couple more things once this is in.

@whitequark
Copy link
Contributor

@phkahler Sorry for the delay, I'll take a look at this soon!

@whitequark
Copy link
Contributor

Thanks, merged!

It looks like the booleans with extrusions are very fragile--I assume that is expected.

@whitequark whitequark closed this Jul 31, 2019
@phkahler
Copy link
Member Author

@whitequark Yes, I've notice that booleans have the most difficulty with compound curved surfaces and twisted surfaces, which we can make a lot of now. I'll be keeping an eye out. Creating shells can be tricky and have bugs even when it seems to work.

@whitequark
Copy link
Contributor

You've made some excellent contributions to SolveSpace, and as such I've invited you to the SolveSpace organization. For now I would still like all non-trivial changes go through pre-commit code review, but feel free to commit trivial ones directly (typos, broken build, etc.)

@phkahler phkahler deleted the helix branch September 10, 2019 20:29
@giannissc giannissc mentioned this pull request Dec 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants