Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.ndg-httpsclient: 0.4.2 -> 0.5.1 #63531

Merged
merged 1 commit into from Jun 23, 2019
Merged

pythonPackages.ndg-httpsclient: 0.4.2 -> 0.5.1 #63531

merged 1 commit into from Jun 23, 2019

Conversation

jonringer
Copy link
Contributor

Motivation for this change

Noticed it was out of date.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.
$ nix-shell -p nix-review --command "nix-review wip"
...
[13 built, 110 copied (141.7 MiB), 37.8 MiB DL]
19 package were build:
beets certbot mopidy-gmusic python27Packages.Quandl python27Packages.acme python27Packages.github3_py python27Packages.gmusicapi python27Packages.gpsoauth python27Packages.lektor python27Packages.ndg-httpsclient python37Packages.acme python37Packages.github3_py python37Packages.gmusicapi python37Packages.gplaycli python37Packages.gpsoauth python37Packages.lektor python37Packages.ndg-httpsclient searx simp_le

$ nix path-info -Sh /nix/store/688plz0xwdwwmb8srfwkbyy3q68sis32-python2.7-ndg-httpsclient-0.4.2
/nix/store/688plz0xwdwwmb8srfwkbyy3q68sis32-python2.7-ndg-httpsclient-0.4.2 102.7M

$ nix path-info -Sh ./result
/nix/store/7iwm6rmvzdygwpj4hsar6x14w813xrxm-python2.7-ndg-httpsclient-0.5.1 102.7M

@jonringer jonringer requested a review from FRidh as a code owner June 19, 2019 18:21
@FRidh FRidh merged commit 9559da7 into NixOS:master Jun 23, 2019
@jonringer jonringer deleted the bump_ndg_httpsclient branch July 9, 2019 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jonringer @FRidh