Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

haskellPackages.hakyll-images: unmark as broken #63530

Merged
merged 1 commit into from Jul 10, 2019
Merged

haskellPackages.hakyll-images: unmark as broken #63530

merged 1 commit into from Jul 10, 2019

Conversation

ghost
Copy link

@ghost ghost commented Jun 19, 2019

Motivation for this change

Builds and works fine now

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ghost
Copy link
Author

ghost commented Jul 9, 2019

cc @peti

@peti peti changed the base branch from master to haskell-updates July 9, 2019 07:54
Copy link
Member

@peti peti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have to remove the build from the list of broken packages in pkgs/development/haskell-modules/configuration-hackage2nix.yaml.

@ghost ghost requested review from FRidh, infinisil and thoughtpolice July 9, 2019 08:02
@peti peti force-pushed the haskell-updates branch 2 times, most recently from 3c3cf28 to 4464d4e Compare July 9, 2019 11:33
@ghost
Copy link
Author

ghost commented Jul 10, 2019

@peti Thank you! Now this PR only changes pkgs/development/haskell-modules/configuration-hackage2nix.yaml. Is anything else required?

@peti peti merged this pull request into NixOS:haskell-updates Jul 10, 2019
@peti
Copy link
Member

peti commented Jul 10, 2019

No, it's fine that way. Thank you.

@ghost ghost deleted the hakyll-images branch July 10, 2019 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant