Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wxGTK31: 3.1.0 -> 3.1.2; use a real derivation #63595

Merged
merged 1 commit into from Jun 24, 2019
Merged

wxGTK31: 3.1.0 -> 3.1.2; use a real derivation #63595

merged 1 commit into from Jun 24, 2019

Conversation

romildo
Copy link
Contributor

@romildo romildo commented Jun 20, 2019

Motivation for this change

  • Uses a real derivation for wxGTK31, instead of overriding wxGTK30 because some configure options for both packages diverge, and the way wxGTK31 is currently defined does not allow overriding it. Fixes wxGTK31 cannot be overriden #63579.

  • Update to version 3.1.2

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@matthewbauer matthewbauer merged commit dc5e4cf into NixOS:master Jun 24, 2019
@romildo romildo deleted the upd.wxgtk branch June 24, 2019 11:37
@ArdaXi ArdaXi mentioned this pull request Nov 13, 2019
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

wxGTK31 cannot be overriden
2 participants
@romildo @matthewbauer