Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

samba: 4.10.4 -> 4.10.5 (security fix) #63594

Merged
merged 1 commit into from Jun 24, 2019
Merged

samba: 4.10.4 -> 4.10.5 (security fix) #63594

merged 1 commit into from Jun 24, 2019

Conversation

risicle
Copy link
Contributor

@risicle risicle commented Jun 20, 2019 •
edited

Motivation for this change

Security release fixing CVE-2019-12435 & CVE-2019-12436

https://www.samba.org/samba/history/samba-4.10.5.html
https://nvd.nist.gov/vuln/detail/CVE-2019-12435
https://nvd.nist.gov/vuln/detail/CVE-2019-12436

I still haven't finished the full nox-review, but thought I should post it anyway.

release-19.03 isn't vulnerable to either.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@risicle
Copy link
Contributor Author

risicle commented Jun 21, 2019

This builds on macos 10.13, with the same reverse dependency failures as 4.10.4.

@risicle
Copy link
Contributor Author

risicle commented Jun 22, 2019

NixOS "samba" test passes too.

@samueldr
Copy link
Member

@GrahamcOfBorg build samba

@samueldr
Copy link
Member

@GrahamcOfBorg test samba

@samueldr samueldr merged commit c925dfb into NixOS:master Jun 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
1.severity: security 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@risicle @samueldr