Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

luarocks: 3.0.4 -> 3.1.3 #63523

Closed
wants to merge 1 commit into from
Closed

Conversation

doronbehar
Copy link
Contributor

@doronbehar doronbehar commented Jun 19, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"- I ran this command but I don't think all Lua packages were rebuild so I'm not sure about this one.
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Also: Updated darwin.patch for new version of the patched file.


Update darwin.patch for new version of the file.
@worldofpeace
Copy link
Contributor

It seems this is already updated on master?

@risicle
Copy link
Contributor

risicle commented Jun 19, 2019

This fails for me non-nixos linux x86_64

building '/nix/store/a79j22ib4b1ynd5qn5f2vi4hfimid4k6-luarocks-nix-3.1.3.drv'...
unpacking sources
unpacking source archive /nix/store/bdia5298mxqqxgz7i0pv0z70821629gh-source
source root is source
patching sources
applying patch /nix/store/djx2aqx0rdwbp4kaw45ga8xgd9759dpj-darwin-3.0.x.patch
patching file src/luarocks/core/cfg.lua
Hunk #1 FAILED at 425.
Hunk #2 succeeded at 436 (offset 2 lines).
1 out of 2 hunks FAILED -- saving rejects to file src/luarocks/core/cfg.lua.rej
builder for '/nix/store/a79j22ib4b1ynd5qn5f2vi4hfimid4k6-luarocks-nix-3.1.3.drv' failed with exit code 1

@doronbehar
Copy link
Contributor Author

Thanks for catching that @worldofpeace , @Shados was faster then me :) Closing.

@doronbehar doronbehar closed this Jun 20, 2019
@worldofpeace
Copy link
Contributor

Yeah we can sometimes have competing PR's since people round here are pretty attentive.

@doronbehar doronbehar deleted the luarocks-update branch March 2, 2023 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants