#40015

@matthewbauer can you please have a look

nox-review builds for me, non-nixos linux x86_64

@GrahamcOfBorg build zabbix

@GrahamcOfBorg build zabbix

@matthewbauer thanks

@PsyanticY @matthewbauer This breaks zabbix for anyone who was running it on NixOS as it entirely removes postgresql support. Please see #63844 for a more thorough implementation which doesn't irreparable break existing installs. Also note that you dropped versions of zabbix which are supported upstream while keeping versions of zabbix which are not.

@aanderse your right about the possibility that dropping postgresql can break for people using it but there was no one using it since the module itself was broke ( notice the extra zabbix_server in the execstart in the systemd unit : serviceConfig.ExecStart = "@${pkgs.zabbix.server}/sbin/zabbix_server zabbix_server --config ${configFile}";) . for the 2.2 and previous version there end of support is august 31 (check this) . I did remove them since many people tried to upgrade zabbix but they got annoyed and dropped it since they needed to manage many packages, Also as a rule of thumb i think in nixpkgs we tend to only keep the latest version on any packages. For your PR i think it is way better then this one since it introduces many more functionalities and options

That isn't broke. That is a systemd feature.

Sorry I think I was confused and thought you dropped 3.0 which is supported, but didn't drop 3.4 which is not supported.

Also while some people argue only keeping latest version is the policy of NixOS this is not the case. NixOS has a flexible policy about keeping LTS releases. See php and postgtesql as examples where we provide our users long term stability, which is very important from my perspective.

@PsyanticY To follow up why this service was not broken I'll quote https://www.freedesktop.org/software/systemd/man/systemd.service.html:

If the executable path is prefixed with "@", the second specified token will be passed as "argv[0]" to the executed process (instead of the actual filename), followed by the further arguments specified.

@aanderse thanks for clearing that out i didn't knew about that.