Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.channels_redis: init at 2.4.0 #63537

Closed
wants to merge 9 commits into from
Closed

pythonPackages.channels_redis: init at 2.4.0 #63537

wants to merge 9 commits into from

Conversation

aakropotkin
Copy link
Contributor

Motivation for this change

Required for project.

Things done

Added "Channels Redis" python module.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@aakropotkin aakropotkin requested a review from FRidh as a code owner June 19, 2019 21:22
@aakropotkin
Copy link
Contributor Author

I needed to merge in dependencies from my other PRs.
I need to clean up my commit logs a bit after doing so.

jonringer
jonringer reviewed Jun 19, 2019
View reviewed changes
pkgs/development/python-modules/hiredis-py/default.nix
pname = "hiredis-py";
version = "1.0.0";

src = fetchurl {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please use fetchPypi over fetchurl when getting pypi packages.

@aakropotkin
Copy link
Contributor Author

Merging multiple PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer left review comments

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aakropotkin @jonringer