Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

usbguard-nox: init at 0.7.4 #63539

Merged
merged 1 commit into from Aug 23, 2019
Merged

usbguard-nox: init at 0.7.4 #63539

merged 1 commit into from Aug 23, 2019

Conversation

ivan
Copy link
Member

@ivan ivan commented Jun 19, 2019

Motivation for this change

I wanted to use usbguard on a server that doesn't need Qt.

This adds usbguard-nox, which is just usbguard without the Qt GUI that brings in Qt dependencies.

Also add an option to the module to select which package to use.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

I confirmed that usbguard and usbguard-nox build, and that the service works with both usbguard and usbguard-nox.

cc maintainer @tnias

@ivan
Copy link
Member Author

ivan commented Jun 19, 2019

@GrahamcOfBorg build usbguard usbguard-nox

@peterhoeg
Copy link
Member

@GrahamcOfBorg build usbguard usbguard-nox

This is just usbguard without the Qt GUI that brings in Qt dependencies.

Remove pandoc to reduce closure size. The usbguard build appears to
use it only for spell checking.

Remove asciidoctor because 0.7.1 switched to asciidoc. But don't add
a dependency on asciidoc, because that causes the build fails on
external DTDs.
@tnias
Copy link
Contributor

tnias commented Jun 22, 2019

Have not tested it. But this looks good to me. :)

@ivan
Copy link
Member Author

ivan commented Aug 16, 2019

I have continued testing usbguard on my desktop which works as it did before, and usbguard-nox on my servers which also runs fine, though I have not tested USB rejection policies there.

@srhb srhb merged commit 3a64303 into NixOS:master Aug 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants