Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/prometheus-node-exporter: fix systemd unit for systemd 242 #63540

Merged
merged 1 commit into from Jun 20, 2019

Conversation

ivan
Copy link
Member

@ivan ivan commented Jun 19, 2019

Motivation for this change

Fix #63383

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

I confirmed that the service starts now.

cc maintainers @benley @fpletz

Avoid having a backslash at the end of ExecStart=.

See NixOS#63533 for details
about the change to systemd's unit parser.

Fixes NixOS#63383.
Copy link
Member

@bachp bachp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on my system and it fixes the issue.

@benley benley merged commit 41c6d7a into NixOS:master Jun 20, 2019
@flokli
Copy link
Contributor

flokli commented Jun 25, 2019

systemd upstream bug: systemd/systemd#12883

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

prometheus-node-exporter.service does not start
4 participants