tor-browser: remove --no-remote option #63527
Conversation
The `-no-remote` option prevents opening new tabs in an running tor-browser session. E.g. executing `tor-browser https://example.com` from the command line always starts a new session regardless of a running instance Please note, I have no clue what the original reason was to add the option `-no-remote`. Maybe this has severe security implications, I simply don't know.
|
I tracked it down all the way to 19ecb7f#diff-f761f1b234f85824da764291f88c1097R196 which was the initial commit. @joachifm do you remember the reason behind the |
|
@kalbasit the motivation is to reduce the risk of mixups when using tor browser along with vanilla firefox at the same time, primarily avoiding sending urls intended for tbb to the vanilla instance. Afair, the upstream wrapper no longer passes this flag explicitly, so this PR would bring us into line with upstream. I do believe upstream is patched to behave as if no-remote was passed by default, however, requiring explicitly passing |
|
@joachifm what's your recommendation? |
|
Thank you for your contributions.
|
stale
bot
added
the
2.status: stale
stale
bot
removed
the
2.status: stale
Motivation for this change
The
-no-remoteoption prevents opening new tabs in an runningtor-browser session. E.g. executing
tor-browser https://example.comfrom the command line always starts a new session regardless of a
running instance
Please note, I have no clue what the original reason was to add the
option
-no-remote. Maybe this has severe security implications, Isimply don't know.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)