Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vagrant: Don't patch salt provisioner's shebang #63529

Merged
merged 1 commit into from Jul 1, 2019

Conversation

samueldr
Copy link
Member

The script is intended to run on remote systems, not on the local
system. The shebang has to work where nix and the current store does
not exist.

Motivation for this change
Things done
  • ☑️ Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • ☑️ NixOS
    • 🔲 macOS
    • 🔲 other Linux distributions
  • 🔲 Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • ☑️ Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • ☑️ Tested execution of all binary files (usually in ./result/bin/)
  • 🔲 Determined the impact on package closure size (by running nix path-info -S before and after)
  • ☑️ Assured whether relevant documentation is up to date
  • ☑️ Fits CONTRIBUTING.md.

The script is intended to run on remote systems, not on the local
system. The shebang **has** to work where nix and the current store does
not exist.
@samueldr samueldr merged commit 86c1103 into NixOS:master Jul 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants