Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

talloc: 2.1.14 -> 2.2.0, also update tevent,ldb,tdb #58380

Closed

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Mar 26, 2019

Motivation for this change

Includes cmocka update (submitted separately)
since new version of ldb requires it.

python inputs are used to execute the build (waf)
but we also expect python bindings to be created
and installed, set inputs accordingly.

Need to check how this works re:cross,
feedback and help testing appreciated :).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Contributor

@matthiasbeyer matthiasbeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff looks good to me.

@0x4A6F
Copy link
Member

0x4A6F commented Nov 8, 2019

@dtzWill Please rebase.

@bbigras bbigras mentioned this pull request Dec 7, 2019
10 tasks
@jtojnar jtojnar self-assigned this Mar 31, 2020
@jtojnar jtojnar mentioned this pull request Mar 31, 2020
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants