Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libjpeg-turbo: 2.0.1 -> 2.0.2, cleanup #58374

Merged
merged 1 commit into from May 8, 2019
Merged

libjpeg-turbo: 2.0.1 -> 2.0.2, cleanup #58374

merged 1 commit into from May 8, 2019

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Mar 26, 2019

Motivation for this change

https://github.com/libjpeg-turbo/libjpeg-turbo/releases/tag/2.0.2

  • patches included, drop
  • use installCheck to avoid needing to set LD_LIBRARY_PATH
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@risicle
Copy link
Contributor

risicle commented Apr 13, 2019

4597 rebuilds by my reckoning

@dtzWill
Copy link
Member Author

dtzWill commented Apr 13, 2019

Yeah, not sure why borg didn't tag it. But there's a reason sent to staging :).

@dtzWill
libjpeg-turbo: 2.0.1 -> 2.0.2, cleanup
6491346 
https://github.com/libjpeg-turbo/libjpeg-turbo/releases/tag/2.0.2

* patches included, drop
* use installCheck to avoid needing to set LD_LIBRARY_PATH
@vcunat vcunat merged commit 6491346 into NixOS:staging May 8, 2019
vcunat added a commit that referenced this pull request May 8, 2019
@vcunat
Merge #58374: libjpeg-turbo: 2.0.1 -> 2.0.2, cleanup
c298a8a 
... into staging
@vcunat vcunat mentioned this pull request May 26, 2019
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcunat vcunat vcunat approved these changes

Assignees
No one assigned
Labels
8.has: package (update) 10.rebuild-darwin: 501+ 10.rebuild-darwin: 1001-2500 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@dtzWill @risicle @vcunat @infinisil @GrahamcOfBorg