Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ansible_2_6: 2.6.9 -> 2.6.15 #58286

Merged
merged 1 commit into from Apr 13, 2019
Merged

ansible_2_6: 2.6.9 -> 2.6.15 #58286

merged 1 commit into from Apr 13, 2019

Conversation

elasticdog
Copy link
Contributor

Motivation for this change

Bump to latest upstream 2.6.x release: https://github.com/ansible/ansible/blob/stable-2.6/changelogs/CHANGELOG-v2.6.rst

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests) N/A
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@elasticdog elasticdog changed the title ansible: 2.6.9 -> 2.6.15 pythonPackages.ansible: 2.6.9 -> 2.6.15 Mar 26, 2019
Copy link
Member

@timokau timokau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :)

Copy link
Member

@timokau timokau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was a bit too quick: Why the pythonPackages prefix? Seems like ansible_2_6 isn't a python library which would be in the pythonPackages package set.

@timokau
Copy link
Member

timokau commented Apr 11, 2019

@GrahamcOfBorg build ansible_2_6

@elasticdog elasticdog changed the title pythonPackages.ansible: 2.6.9 -> 2.6.15 ansible_2_6: 2.6.9 -> 2.6.15 Apr 12, 2019
@elasticdog
Copy link
Contributor Author

@timokau You're right...I had copied/pasted without thinking. Fixed the commit message and PR title to reflect the proper package name (thank you @dotlambda for the clarification in the other thread).

@dotlambda
Copy link
Member

@GrahamcOfBorg build ansible_2_6

@dotlambda dotlambda merged commit 290be50 into NixOS:master Apr 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants