Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to compile on Linux #2109

Merged
merged 3 commits into from
Mar 25, 2019
Merged

Changes to compile on Linux #2109

merged 3 commits into from
Mar 25, 2019

Conversation

pleroy
Copy link
Member

@pleroy pleroy commented Mar 24, 2019

No description provided.

@eggrobin eggrobin added the LGTM label Mar 24, 2019
@lamont-granquist
Copy link
Contributor

stops now at:

In file included from astronomy/standard_product_3.cpp:1:
In file included from ./astronomy/standard_product_3.hpp:9:
In file included from ./astronomy/frames.hpp:6:
In file included from ./geometry/frame.hpp:8:
In file included from ./geometry/named_quantities.hpp:6:
In file included from ./geometry/affine_map.hpp:4:
In file included from ./geometry/point.hpp:138:
In file included from ./geometry/point_body.hpp:10:
In file included from ./geometry/grassmann.hpp:9:
./geometry/r3_element.hpp:64:5: warning: anonymous structs are a GNU extension [-Wgnu-anonymous-struct]
    struct {
    ^
./geometry/r3_element.hpp:69:5: warning: anonymous structs are a GNU extension [-Wgnu-anonymous-struct]
    struct {
    ^
./geometry/r3_element.hpp:64:5: warning: anonymous types declared in an anonymous union are an extension [-Wnested-anon-types]
    struct {
    ^
./geometry/r3_element.hpp:69:5: warning: anonymous types declared in an anonymous union are an extension [-Wnested-anon-types]
    struct {
    ^
astronomy/standard_product_3.cpp:44:40: error: no member named 'string' in 'std::filesystem::path'
      location = absl::StrCat(filename.string(), " at end of file");
                              ~~~~~~~~ ^
fatal error: too many errors emitted, stopping now [-ferror-limit=]
12 warnings and 2 errors generated.
make: *** [obj/astronomy/standard_product_3.o] Error 1

@pleroy
Copy link
Member Author

pleroy commented Mar 25, 2019

It looks like https://github.com/mockingbirdnest/Compatibility/blob/master/filesystem/filesystem is missing the string function. One day, I'm sure, Apple will support C++17...

@pleroy
Copy link
Member Author

pleroy commented Mar 25, 2019

mockingbirdnest/Compatibility@5686397 should help. @eggrobin is going to try it.

Sorry, something went wrong.

@pleroy pleroy merged commit 15e157e into mockingbirdnest:master Mar 25, 2019
@pleroy
Copy link
Member Author

pleroy commented Mar 25, 2019

@lamont-granquist: I am told that with the above change it builds on Mac. You'll need to pull the Compatibility repository.

Sorry, something went wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants