Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
base: 9e693a074d0c
Choose a base ref
...
head repository: NixOS/nixpkgs
compare: 7be93a4ca750
Choose a head ref
  • 2 commits
  • 1 file changed
  • 2 contributors

Commits on Mar 25, 2019

  1. buildRustCrate: Fix include filter 

    buildRustCrate has a handy `include` helper, that only imports those whitelisted
files and folders to the store.

However, the function's matching logic is broken and includes all files,
regardless of whether or not they're whitelisted, as long as the whitelist
contains at least one name (regardless of whether that name exists). This is
because it doesn't take into account that
`lib.strings.removePrefix "foo" "bar" == "bar"` (that is, paths that don't match
the prefix are passed straight through).
    @nightkr
    nightkr committed Mar 25, 2019
    Copy the full SHA
    5eec83e View commit details
    Browse the repository at this point in the history

  2. Merge pull request #58258 from teozkr/buildRustCrate-fix-include 

    buildRustCrate: Fix `include` filter
    @dywedir
    dywedir committed Mar 25, 2019
    Copy the full SHA
    7be93a4 View commit details
    Browse the repository at this point in the history