Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ansible_2_5: 2.5.14 -> 2.5.15 #58287

Merged
merged 1 commit into from Apr 13, 2019
Merged

ansible_2_5: 2.5.14 -> 2.5.15 #58287

merged 1 commit into from Apr 13, 2019

Conversation

elasticdog
Copy link
Contributor

Motivation for this change

Bump to latest upstream 2.5.x release: https://github.com/ansible/ansible/blob/stable-2.5/changelogs/CHANGELOG-v2.5.rst

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests) N/A
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@elasticdog elasticdog changed the title ansible: 2.5.14 -> 2.5.15 pythonPackages.ansible: 2.5.14 -> 2.5.15 Mar 26, 2019
timokau
timokau requested changes Apr 11, 2019
View reviewed changes
Copy link
Member

@timokau timokau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the pythonPackages prefix?

@timokau
Copy link
Member

timokau commented Apr 11, 2019

@GrahamcOfBorg build ansible_2_5

@elasticdog
Copy link
Contributor Author

@timokau I changed the title after @dotlambda added it to my other PR for Ansible 2.7 (#58285), but I think they might have done that out of historical habit?

@elasticdog
Copy link
Contributor Author

Same as the other branch: #58287 (comment) I'd be glad to change the PR title back, if it matters for posterity.

dotlambda
dotlambda requested changes Apr 12, 2019
View reviewed changes
Copy link
Member

@dotlambda dotlambda left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pythonPackages.ansible refers to version 2.7.9. This update is for ansible_2_5. This should be reflected in the commit message.

@dotlambda dotlambda changed the title pythonPackages.ansible: 2.5.14 -> 2.5.15 ansible_2_5: 2.5.14 -> 2.5.15 Apr 12, 2019
@elasticdog
Copy link
Contributor Author

@dotlambda fixed, thanks.

@dotlambda
Copy link
Member

@GrahamcOfBorg build ansible_2_5

@dotlambda dotlambda merged commit dcf5fd5 into NixOS:master Apr 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timokau timokau timokau requested changes

@dotlambda dotlambda dotlambda requested changes

Assignees
No one assigned
Labels
8.has: package (update) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@elasticdog @timokau @dotlambda @infinisil @GrahamcOfBorg