Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

idrisPackages.glfw: Fix runtime #58320

Merged
merged 1 commit into from Apr 28, 2019
Merged

idrisPackages.glfw: Fix runtime #58320

merged 1 commit into from Apr 28, 2019

Conversation

infinisil
Copy link
Member

@infinisil infinisil commented Mar 26, 2019 •
edited

Fixes #55086

Ping @locallycompact

In order to run programs, pkgconfig needs to be present so it can tell
it where to find glfw3 and gl.

The general idris fix in #58319 is also needed for it to work

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@infinisil
idrisPackages.glfw: Fix runtime
321ec86 
In order to run programs, pkgconfig needs to be present so it can tell
it where to find glfw3 and gl.
@infinisil infinisil merged commit 93143b0 into NixOS:master Apr 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

idris glfw failing to link/run
2 participants
@infinisil @GrahamcOfBorg