Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drawing vertical/horizontal lines of width>1 problem #6865

Closed
J0anJosep opened this issue Jul 23, 2018 · 3 comments
Closed

Drawing vertical/horizontal lines of width>1 problem #6865

J0anJosep opened this issue Jul 23, 2018 · 3 comments
Labels
bug Something isn't working needs triage This issue needs further investigation before it becomes actionable stale Stale issues

Comments

@J0anJosep
Copy link
Contributor

Blitter doesn't draw lines of width > 1 correctly:

  1. Sometimes there are some pixels moved at the beginning or end of the line.
  2. The width of the line doesn't match the one passed as an argument.

GfxDrawLine(x_zero, y_zero, x_zero, y_max, _colour_gradient[COLOUR_BLUE][1], 4);
GfxDrawLine(x_max, y_zero, x_max, y_max, _colour_gradient[COLOUR_BLUE][1], 5);
See attached image:
lines
... where the left line should have a width of 5 and the right one a width of 4 pixels (and they have a width of 4 and 3 respectively).
@nielsmh
Copy link
Contributor

nielsmh commented Nov 4, 2018 •
edited

I can't reproduce the thickness issue.

GfxDrawLine(x_zero +  0, y_zero, x_zero +  0, y_max, 1, 1);
GfxDrawLine(x_zero +  5, y_zero, x_zero +  5, y_max, 1, 2);
GfxDrawLine(x_zero + 10, y_zero, x_zero + 10, y_max, 1, 3);
GfxDrawLine(x_zero + 15, y_zero, x_zero + 15, y_max, 1, 4);
GfxDrawLine(x_zero + 22, y_zero, x_zero + 22, y_max, 1, 5);
GfxDrawLine(x_zero + 30, y_zero, x_zero + 30, y_max, 1, 6);

image

@andythenorth andythenorth added needs triage This issue needs further investigation before it becomes actionable bug Something isn't working stale Stale issues labels Jan 5, 2019
@andythenorth
Copy link
Contributor

So do we have a repro or not? :)

@andythenorth andythenorth removed the stale Stale issues label Jan 24, 2019
@stale
Copy link

stale bot commented Mar 25, 2019

This issue has been automatically marked as stale because it has not had any activity in the last two months.
If you believe the issue is still relevant, please test on the latest nightly and report back.
It will be closed if no further activity occurs within 7 days.
Thank you for your contributions.

@stale stale bot added the stale Stale issues label Mar 25, 2019
@stale stale bot closed this as completed Apr 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working needs triage This issue needs further investigation before it becomes actionable stale Stale issues
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nielsmh @andythenorth @J0anJosep