Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vimPlugins.vim-stylish-haskell: Patch path to executable #58409

Merged
merged 2 commits into from Apr 1, 2019

Conversation

infinisil
Copy link
Member

Motivation for this change

Closes #57099

As one would expect, this increases the closure size of vimPlugins.vim-stylish-haskell by a lot, from 3.1KB to 40.6MB, but this is worth it and makes sense.

Tested this by doing

$ cd /path/to/nixpkgs
$ nix-build -E 'with import ./. {}; neovim.override { configure = { packages.myVimPackage = with pkgs.vimPlugins; { start = [  vim-stylish-haskell ]; }; }; }'
$ export PATH=""
$ result/bin/nvim

Then opening a non-stylished Haskell file (such as https://github.com/mrkkrp/megaparsec/blob/master/Text/Megaparsec.hs) and hitting :w -> stylish does the styling.

Ping @lrworth

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants