Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

linux_testing_bcachefs,bcachefs-tools: 2019-04-04 #58296

Merged
merged 2 commits into from Apr 26, 2019
Merged

linux_testing_bcachefs,bcachefs-tools: 2019-04-04 #58296

merged 2 commits into from Apr 26, 2019

Conversation

eadwu
Copy link
Member

@eadwu eadwu commented Mar 25, 2019 •
edited

Only tested bcachefs-tools.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@eadwu eadwu changed the title linux_testing_bcachefs,bcachefs-tools: 2019-03-24 linux_testing_bcachefs,bcachefs-tools: 2019-03-29 Mar 29, 2019
@eadwu
Copy link
Member Author

eadwu commented Mar 29, 2019 •
edited

At least bcachefs-tools is broken on 2019-03-29.

Looks like it was fixed on 2019-04-04.

@eadwu eadwu changed the title linux_testing_bcachefs,bcachefs-tools: 2019-03-29 linux_testing_bcachefs,bcachefs-tools: 2019-04-04 Apr 6, 2019
@eadwu eadwu changed the title linux_testing_bcachefs,bcachefs-tools: 2019-04-04 linux_testing_bcachefs,bcachefs-tools: 2019-04-18 Apr 19, 2019
@eadwu eadwu changed the title linux_testing_bcachefs,bcachefs-tools: 2019-04-18 linux_testing_bcachefs,bcachefs-tools: 2019-04-04 Apr 26, 2019
@dywedir
Copy link
Member

dywedir commented Apr 26, 2019

Thank you!

@dywedir dywedir merged commit e8c2633 into NixOS:master Apr 26, 2019
@eadwu eadwu deleted the bcachefs/update-1 branch November 17, 2020 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (update) 10.rebuild-darwin: 0 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@eadwu @dywedir @infinisil @GrahamcOfBorg