Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aragorn: init at 1.2.38 #58354

Merged
merged 2 commits into from Apr 29, 2019
Merged

aragorn: init at 1.2.38 #58354

merged 2 commits into from Apr 29, 2019

Conversation

bzizou
Copy link
Contributor

@bzizou bzizou commented Mar 26, 2019

Motivation for this change

Soft needed by the biologists using our computing center (GRICAD)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@aanderse
Copy link
Member

aanderse commented Apr 14, 2019

@GrahamcOfBorg build aragorn

Copy link
Member

@kalbasit kalbasit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a nitpick. Overall it looks good.

@@ -0,0 +1,28 @@
{stdenv, fetchurl }:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{stdenv, fetchurl }:
{ stdenv, fetchurl }:

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I commited the suggestion. Should I squash the 2 commits and force-push ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please.

Co-Authored-By: bzizou <Bruno.Bzeznik@imag.fr>
@aanderse aanderse merged commit 83886b3 into NixOS:master Apr 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants