Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lacaml: Use propagatedBuildInputs for stublibs #58449

Merged
merged 1 commit into from Sep 29, 2019
Merged

lacaml: Use propagatedBuildInputs for stublibs #58449

merged 1 commit into from Sep 29, 2019

Conversation

rixed
Copy link
Contributor

@rixed rixed commented Mar 27, 2019

Motivation for this change

This frees the packages depending on lacaml to have to repeat this.
Other ocaml libs seems to do the same for stubs.
Cf discussion in #57954

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@rixed
lacaml: Use propagatedBuildInputs for stublibs
de40fe7 
This frees the packages depending on lacaml to have to repeat this.
@rixed
Copy link
Contributor Author

rixed commented Jul 28, 2019

So what's the status regarding this patch?

manveru
manveru approved these changes Sep 28, 2019
View reviewed changes
Copy link
Contributor

@manveru manveru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW, It builds fine for me.

@vbgl vbgl merged commit 94560d7 into NixOS:master Sep 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manveru manveru manveru approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rixed @manveru @vbgl @GrahamcOfBorg