Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python.pkgs.pybullet: init at 2.4.8 #58448

Merged
merged 1 commit into from Mar 27, 2019
Merged

python.pkgs.pybullet: init at 2.4.8 #58448

merged 1 commit into from Mar 27, 2019

Conversation

timokau
Copy link
Member

@timokau timokau commented Mar 27, 2019 •
edited

Motivation for this change

Making the openai gym usable without the proprietary mujoco physics engine (this uses bullet instead).

This is the actively developed version from the bullet maintainers, as opposed to the version from the gym maintainers in #58451 which has only maintenance support but is still relevant.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@timokau timokau requested a review from FRidh as a code owner March 27, 2019 17:47
@timokau
Copy link
Member Author

timokau commented Mar 27, 2019

@GrahamcOfBorg build python2.pkgs.roboschool python3.pkgs.roboschool

@timokau timokau changed the title python.pkgs.pybullet: init at 1.0.39 python.pkgs.roboschool: init at 1.0.39 Mar 27, 2019
@timokau timokau changed the title python.pkgs.roboschool: init at 1.0.39 python.pkgs.pybullet: init at 2.4.8 Mar 27, 2019
@timokau
Copy link
Member Author

timokau commented Mar 27, 2019

Oops, little mixup.

@GrahamcOfBorg build python2.pkgs.roboschool python3.pkgs.pybullet

@timokau
Copy link
Member Author

timokau commented Mar 27, 2019 •
edited

And again..

@GrahamcOfBorg build python2.pkgs.pybullet python3.pkgs.pybullet

@timokau
Copy link
Member Author

timokau commented Mar 27, 2019

@GrahamcOfBorg eval

@timokau
Copy link
Member Author

timokau commented Mar 27, 2019

@GrahamcOfBorg eval
@GrahamcOfBorg build python2.pkgs.pybullet python3.pkgs.pybullet

@timokau
Copy link
Member Author

timokau commented Mar 27, 2019

@GrahamcOfBorg build python2.pkgs.pybullet python3.pkgs.pybullet

@timokau timokau merged commit 197bc2a into NixOS:master Mar 27, 2019
@timokau timokau deleted the pybullet-init branch March 27, 2019 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@timokau @GrahamcOfBorg