Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gnulib: 20180226 -> 20190326 #58416

Merged
merged 2 commits into from Apr 25, 2019
Merged

gnulib: 20180226 -> 20190326 #58416

merged 2 commits into from Apr 25, 2019

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Mar 26, 2019

Motivation for this change

Lots of fixes, support for goodness such as RISC-V and cross-musl
(apparently!):

http://git.savannah.gnu.org/gitweb/?p=gnulib.git;a=shortlog;h=a18f7ce3c0aa760c33d46bbeb8e5b3a14cf24984;hp=0bec5d56c6938c2f28417bb5fd1c4b05ea2e7d28

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@c0bw3b
Copy link
Contributor

c0bw3b commented Apr 24, 2019

@GrahamcOfBorg eval

@c0bw3b
Copy link
Contributor

c0bw3b commented Apr 24, 2019

@GrahamcOfBorg build fontforge gnu-pw-mgr xprintidle-ng

@c0bw3b c0bw3b self-assigned this Apr 25, 2019
@c0bw3b
xprintidle-ng: refactor and patch configure.ac
e2fd727 
configure.ac needs to be patched in order to build with newer gnulib
See NixOS#58416
@ofborg ofborg bot requested a review from 7c6f434c April 25, 2019 17:27
c0bw3b
c0bw3b approved these changes Apr 25, 2019
View reviewed changes
Copy link
Contributor

@c0bw3b c0bw3b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Local nix-review is good.
Built and ran : [ fontforge gnulib gnu-pw-mgr xprintidle-ng ]

@c0bw3b c0bw3b merged commit f3558ac into NixOS:staging Apr 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c0bw3b c0bw3b c0bw3b approved these changes

@7c6f434c 7c6f434c Awaiting requested review from 7c6f434c

Assignees

@c0bw3b c0bw3b

Labels
8.has: package (update) 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dtzWill @c0bw3b @infinisil