Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

terminator: fix missing gobject bindings #58447

Merged
merged 1 commit into from Mar 27, 2019
Merged

terminator: fix missing gobject bindings #58447

merged 1 commit into from Mar 27, 2019

Conversation

borisbabic
Copy link
Contributor

See: #56943

Motivation for this change

Terminator doesn't work because of #56943. This same fix has been applied elsewhere as well, example: 64c8f26

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • [] Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

worldofpeace
worldofpeace approved these changes Mar 27, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be fine for now.
Builds and executes for me locally.

@worldofpeace worldofpeace merged commit 8137fa5 into NixOS:master Mar 27, 2019
@worldofpeace
Copy link
Contributor

Thank you @borisbabic 🌟

@pirboazo
Copy link

Hi
After upgrade to 19.03
when i launch terminator
I receive message install python binding for gobject, gtk , pango.

@worldofpeace
Copy link
Contributor

@pirboazo So that makes sense that you found this pr then.

I've backported this to 19.03 386a21d.
Note there may be more programs that are effected by #56943.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace approved these changes

@bjornfor bjornfor Awaiting requested review from bjornfor

@globin globin Awaiting requested review from globin

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@borisbabic @worldofpeace @pirboazo @GrahamcOfBorg