Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fcitx: 4.2.9.5 -> 4.2.9.6 #58442

Merged
merged 1 commit into from Apr 8, 2019
Merged

fcitx: 4.2.9.5 -> 4.2.9.6 #58442

merged 1 commit into from Apr 8, 2019

Conversation

teto
Copy link
Member

@teto teto commented Mar 27, 2019 •
edited

Updated url to gitlab.

Motivation for this change

none, was looking into how I could input arabic.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@teto
fcitx: 4.2.9.5 -> 4.2.9.6
c375715 
Updated url to gitlab.
aanderse
aanderse requested changes Apr 8, 2019
View reviewed changes
Copy link
Member

@aanderse aanderse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@teto can you please add a comment to this github PR thread to provide any sort of proof that the gitlab repo you are referencing belongs to the developers.

@teto
Copy link
Member Author

teto commented Apr 8, 2019

Right, I should have written so earlier: see the headline of https://github.com/fcitx ("We are moving to https://gitlab.com/fcitx")

aanderse
aanderse approved these changes Apr 8, 2019
View reviewed changes
Copy link
Member

@aanderse aanderse left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This branch builds on my x86_64 NixOS machine.

LGTM 👍

@nixos-discourse
Copy link

This pull request has been mentioned on Nix community. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/13

@ryantm ryantm merged commit 70723a9 into NixOS:master Apr 8, 2019
@teto teto deleted the fcitx_bump branch April 8, 2019 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aanderse aanderse aanderse approved these changes

Assignees
No one assigned
Labels
8.has: package (update) 10.rebuild-darwin: 0 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@teto @nixos-discourse @aanderse @ryantm @infinisil @GrahamcOfBorg