Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

postgresqlPackages.pipelinedb: init at 1.0.0-13 #58441

Merged
merged 1 commit into from May 18, 2019
Merged

postgresqlPackages.pipelinedb: init at 1.0.0-13 #58441

merged 1 commit into from May 18, 2019

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Mar 27, 2019

Motivation for this change

Add https://www.pipelinedb.com/

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@symphorien
Copy link
Member

I can reproduce the failure of OfBorg on x86_64-linux.

symphorien
symphorien reviewed Mar 28, 2019
View reviewed changes
pkgs/servers/sql/postgresql/ext/pipelinedb.nix
'';

installPhase = ''
mkdir -p $out/bin
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like you install nothing in $out/bin

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is required because an issue with PostgreSQL extraPlugins #22653; fwiw I have another PR to address it #58251

@marsam
Copy link
Contributor Author

marsam commented Mar 28, 2019

PipelineDB supports PostgreSQL versions 10 and 11, ofborg is failing because currently nixpkgs uses by default PostgreSQL 9.6. I'm not sure how to restrict the supported PostgreSQL versions

@symphorien
Copy link
Member

symphorien commented Mar 28, 2019 •
edited

Ah ok, my bad, it builds then. But $out/bin is empty; I guess you don't need to create it ? I just saw your other comment, sorry.

@marsam marsam force-pushed the init-postgresql-pipelinedb branch from 9307c4e to 3fb9487 Compare March 31, 2019 01:02
@risicle
Copy link
Contributor

risicle commented Apr 13, 2019

That's interesting - you could always check postgresql package version and conditionally throw an "unsupported" string, causing the package to be skipped by hydra, nox et al. But of course there not being any other auto-built postgresqlPackages versions, this would leave your package not being auto-built or included in any automatic checks etc.

@marsam marsam force-pushed the init-postgresql-pipelinedb branch from 3fb9487 to d4d710c Compare April 13, 2019 19:26
@marsam marsam merged commit 60277c7 into NixOS:master May 18, 2019
@marsam marsam deleted the init-postgresql-pipelinedb branch May 18, 2019 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@symphorien symphorien symphorien left review comments

@thoughtpolice thoughtpolice Awaiting requested review from thoughtpolice thoughtpolice is a code owner

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 0 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@marsam @symphorien @risicle @GrahamcOfBorg