Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

golangci-lint: 1.9.2 -> 1.16.0 #58336

Merged
merged 2 commits into from May 22, 2019
Merged

Conversation

anpryl
Copy link
Contributor

@anpryl anpryl commented Mar 26, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@aneeshusa
Copy link
Contributor

v1.16.0 was released a week ago and pulls in almost 2 months of additional fixes (v1.15.0 was released Feb 18). Could you bump this to the latest?

@aneeshusa
Copy link
Contributor

It would also be nice to try to use the new buildGoModule support in nixpkgs.

@anpryl anpryl changed the title golangci-lint: 1.9.2 -> 1.15.0 [WIP] golangci-lint: 1.9.2 -> 1.15.0 Apr 8, 2019
@anpryl
Copy link
Contributor Author

anpryl commented Apr 8, 2019

Ok, don't merge this please, I will update PR soon

@anpryl anpryl changed the title [WIP] golangci-lint: 1.9.2 -> 1.15.0 golangci-lint: 1.9.2 -> 1.16.0 Apr 28, 2019
@anpryl
Copy link
Contributor Author

anpryl commented Apr 28, 2019

Updated to latest version using buildGoModule, can be merged now.

@kalbasit
Copy link
Member

Getting an error building this locally:

$ nix build --no-link --keep-going --max-jobs 8 --option build-use-sandbox true -f /yl/.cache/nix-review/pr-58336/build.nix
hash mismatch in fixed-output derivation '/nix/store/xf54c6fwph4dip4mjqljnpj6mhbp0456-source':
  wanted: sha256:0jq434hq56xb7r7pdjykxx8jxr107djzk24dwzhjs9ynqfdv9k4v
  got:    sha256:1yzcfmrxyrxhq3vx13qm7czvhvdnaqay75v8ry1lgpg0bnh9pakx
cannot build derivation '/nix/store/r94y9l6wd5vaycfnng3xyj6si38nm5jj-golangci-lint-1.16.0-go-modules.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/vg5k969mrxy4c83hg8bw5fxjdwbkalaf-golangci-lint-1.16.0.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/yprpzx5z6l9zk1ici9jmshk8wccm2px9-env.drv': 1 dependencies couldn't be built
[0 built (1 failed), 13 copied (6.1 MiB), 1.5 MiB DL]
error: build of '/nix/store/yprpzx5z6l9zk1ici9jmshk8wccm2px9-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/58336
1 package failed to build:
golangci-lint

@GrahamcOfBorg build golangci-lint

@anpryl
Copy link
Contributor Author

anpryl commented Apr 30, 2019

@GrahamcOfBorg build golangci-lint

@anpryl
Copy link
Contributor Author

anpryl commented Apr 30, 2019

Getting an error building this locally:

$ nix build --no-link --keep-going --max-jobs 8 --option build-use-sandbox true -f /yl/.cache/nix-review/pr-58336/build.nix
hash mismatch in fixed-output derivation '/nix/store/xf54c6fwph4dip4mjqljnpj6mhbp0456-source':
  wanted: sha256:0jq434hq56xb7r7pdjykxx8jxr107djzk24dwzhjs9ynqfdv9k4v
  got:    sha256:1yzcfmrxyrxhq3vx13qm7czvhvdnaqay75v8ry1lgpg0bnh9pakx
cannot build derivation '/nix/store/r94y9l6wd5vaycfnng3xyj6si38nm5jj-golangci-lint-1.16.0-go-modules.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/vg5k969mrxy4c83hg8bw5fxjdwbkalaf-golangci-lint-1.16.0.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/yprpzx5z6l9zk1ici9jmshk8wccm2px9-env.drv': 1 dependencies couldn't be built
[0 built (1 failed), 13 copied (6.1 MiB), 1.5 MiB DL]
error: build of '/nix/store/yprpzx5z6l9zk1ici9jmshk8wccm2px9-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/58336
1 package failed to build:
golangci-lint

@GrahamcOfBorg build golangci-lint

Very strange behavior. Locally it was fine. Rebased on the newest master.

@kalbasit
Copy link
Member

Let's try again. @GrahamcOfBorg build golangci-lint

@kalbasit
Copy link
Member

@GrahamcOfBorg build golangci-lint

Copy link
Member

@kalbasit kalbasit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please squash 40f4e1f3611bb39d649d5d6c39f87c16681394e7 into ac0add6d7b4115c4605ad922c3f04d8afaecd997.

@kalbasit
Copy link
Member

I believe I know why the hash did not work before, and now it does. Go 1.12 seems to have added a new empty file with the mods and it's changing the hash :( We should update existing packages that are affected by the 1.12 update.

@anpryl
Copy link
Contributor Author

anpryl commented Apr 30, 2019

please squash 40f4e1f into ac0add6.

Done

@ofborg ofborg bot requested a review from kalbasit April 30, 2019 11:27
@kalbasit
Copy link
Member

@GrahamcOfBorg build golangci-lint

@anpryl
Copy link
Contributor Author

anpryl commented May 22, 2019

@kalbasit ping

@kalbasit
Copy link
Member

@GrahamcOfBorg build golangci-lint

@kalbasit
Copy link
Member

I'm not sure why it's failing on Darwin, but it's working on my side.

@kalbasit kalbasit merged commit ad2e3b9 into NixOS:master May 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants