New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
golangci-lint: 1.9.2 -> 1.16.0 #58336
Conversation
v1.16.0 was released a week ago and pulls in almost 2 months of additional fixes (v1.15.0 was released Feb 18). Could you bump this to the latest? |
It would also be nice to try to use the new |
Ok, don't merge this please, I will update PR soon |
3fedda1
to
bb8ed4d
Compare
Updated to latest version using buildGoModule, can be merged now. |
Getting an error building this locally:
@GrahamcOfBorg build golangci-lint |
bb8ed4d
to
40f4e1f
Compare
@GrahamcOfBorg build golangci-lint |
Very strange behavior. Locally it was fine. Rebased on the newest master. |
Let's try again. @GrahamcOfBorg build golangci-lint |
@GrahamcOfBorg build golangci-lint |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please squash 40f4e1f3611bb39d649d5d6c39f87c16681394e7 into ac0add6d7b4115c4605ad922c3f04d8afaecd997.
I believe I know why the hash did not work before, and now it does. Go 1.12 seems to have added a new empty file with the mods and it's changing the hash :( We should update existing packages that are affected by the 1.12 update. |
40f4e1f
to
aed3c7c
Compare
@GrahamcOfBorg build golangci-lint |
@kalbasit ping |
@GrahamcOfBorg build golangci-lint |
I'm not sure why it's failing on Darwin, but it's working on my side. |
Motivation for this change
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)