Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove a bunch of old option renames #58420

Merged
merged 1 commit into from Mar 29, 2019
Merged

Remove a bunch of old option renames #58420

merged 1 commit into from Mar 29, 2019

Conversation

infinisil
Copy link
Member

Motivation for this change

I don't think we need to provide backwards compatibility for warnings that have been issues for 4 years by now :)

Which ones to remove was decided based on the date given by git blame rename.nix, I removed all mkRenamedOptionModule from 2015 (or earlier, but there are no earlier ones).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@infinisil
nixos/modules: Remove about 50 option renames from <=2015
2a72707 
These are all `mkRenamedOptionModule` ones from 2015 (there are none
from 2014). `mkAliasOptionModule` from 2015 were left in because those
don't give any warning at all.
@matthewbauer
Copy link
Member

👎 on this. Keeping these around is cheap and sends a good message that we are willing to support old configs.

@infinisil
Copy link
Member Author

[...] sends a good message that we are willing to support old configs

We still have another >200 options in that file, I think that still brings our message across.

And 4 years is more than enough of a deprecation time. We should be a bit more open to removing cruft imo.

flokli
flokli approved these changes Mar 29, 2019
View reviewed changes
Copy link
Contributor

@flokli flokli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also guess after showing rename warnings for 4 years, we can slowly clean things up ;-)

@flokli flokli merged commit a6abf97 into NixOS:master Mar 29, 2019
@infinisil infinisil deleted the remove-renames branch April 1, 2019 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 approved these changes

@flokli flokli flokli approved these changes

@Ma27 Ma27 Ma27 approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@infinisil @matthewbauer @Mic92 @flokli @Ma27 @GrahamcOfBorg