Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tzdata: 2018g -> 2019a #58347

Merged
merged 1 commit into from Mar 27, 2019
Merged

tzdata: 2018g -> 2019a #58347

merged 1 commit into from Mar 27, 2019

Conversation

andir
Copy link
Member

@andir andir commented Mar 26, 2019 •
edited

Motivation for this change

Upstream released a new version.

http://mm.icann.org/pipermail/tz-announce/2019-March/000055.html

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

This was referenced Mar 26, 2019
Merged
Merged
@veprbl
Copy link
Member

veprbl commented Mar 26, 2019

Should go to staging?

@andir
Copy link
Member Author

andir commented Mar 27, 2019

Oh, yes. I somehow confused the rebuild amount with another PR I was preparing at the time.. Will rebase to staging.

@andir andir changed the base branch from master to staging-next March 27, 2019 08:07
@andir
Copy link
Member Author

andir commented Mar 27, 2019 •
edited

@veprbl I rebased this onto staging-next and the backports PR on the respective release-XX.XX branches.

@flokli
Copy link
Contributor

flokli commented Mar 27, 2019

I don't see this breaking eval, merged manually into current staging-next (b40d752) and successfully built and ran dateutils.

@flokli flokli merged commit 48b449c into NixOS:staging-next Mar 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpletz fpletz Awaiting requested review from fpletz

Assignees
No one assigned
Labels
8.has: clean-up 8.has: package (new) 10.rebuild-darwin: 501+ 10.rebuild-darwin: 2501-5000 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@andir @veprbl @flokli @GrahamcOfBorg